Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation #383

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Fix documentation #383

merged 3 commits into from
Dec 19, 2023

Conversation

nupuruttarwar
Copy link
Collaborator

Fix linux networking documentation and update few guides according to IPU SDK procedure

docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-lnw-overlay-vms.md Outdated Show resolved Hide resolved
Fix linux networking documentation and update few guides according
to IPU SDK procedure

Signed-off-by: nupuruttarwar <[email protected]>
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/apps/lnw/es2k/es2k-linux-networking.md Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-lnw-overlay-vms.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-lnw-overlay-vms.md Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-lnw-overlay-vms.md Outdated Show resolved Hide resolved
docs/guides/es2k/deploying-p4-programs.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-lnw-overlay-vms.md Show resolved Hide resolved
@ffoulkes ffoulkes added documentation Improvements or additions to documentation medium effort Moderate effort required labels Dec 15, 2023
@nupuruttarwar nupuruttarwar marked this pull request as ready for review December 16, 2023 04:59
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions for edit. Rest LGTM

docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Show resolved Hide resolved
Signed-off-by: nupuruttarwar <[email protected]>
Copy link
Contributor

@vsureshkumarp vsureshkumarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...:)

@5abeel 5abeel merged commit c3a04f5 into main Dec 19, 2023
5 checks passed
@5abeel 5abeel deleted the fix_docs branch December 19, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation medium effort Moderate effort required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants